Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linebreak in description #424

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Fix linebreak in description #424

merged 2 commits into from
Jun 3, 2020

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented May 28, 2020

Now shows line-breaks also in submit-view.

@jancborchardt Found a branch, that increased the line-height, but was no PR, yet. Just cherry-picked your commit from there. I think this is in your intention? ;) Only thing is that i removed your !important again from font-size. Do you still see any issue here on the font-size? I don't...

jotoeri and others added 2 commits May 25, 2020 19:03
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jotoeri jotoeri added bug Something isn't working design Related to the design 3. to review Waiting for reviews labels May 28, 2020
@jotoeri jotoeri added this to the 2.0 milestone May 28, 2020
@jancborchardt jancborchardt mentioned this pull request May 28, 2020
63 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #424 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #424   +/-   ##
========================================
  Coverage      0.00%   0.00%           
  Complexity      195     195           
========================================
  Files            17      17           
  Lines          1066    1064    -2     
========================================
+ Misses         1066    1064    -2     
Impacted Files Coverage Δ Complexity Δ
lib/Controller/ApiController.php 0.00% <0.00%> (ø) 80.00 <0.00> (ø)
lib/Controller/PageController.php 0.00% <0.00%> (ø) 16.00 <0.00> (ø)
lib/Service/FormsService.php 0.00% <0.00%> (ø) 26.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ff718...4d8022f. Read the comment docs.

@jancborchardt
Copy link
Member

Found a branch, that increased the line-height, but was no PR, yet. Just cherry-picked your commit from there. I think this is in your intention? ;) Only thing is that i removed your !important again from font-size. Do you still see any issue here on the font-size? I don't...

Heh, thanks a lot! :) I only didn’t open a pull request for that yet since I wanted to test out if the !important was needed, but then I promptly forgot. ;)

@jotoeri
Copy link
Member Author

jotoeri commented May 28, 2020

:D 👍

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Jan is ok with this, i'm too!

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! And thanks for including the line-height fix directly. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design feature: 📑 form creation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants