-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow navigation through edit via Tab-Key #427
Conversation
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
========================================
Coverage 0.00% 0.00%
Complexity 196 196
========================================
Files 17 17
Lines 1063 1063
========================================
Misses 1063 1063 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small fix needed as discussed, ref my review in the Vue components pull request :) nextcloud-libraries/nextcloud-vue#1126 (comment)
Copied from vue-PR:
|
3b9a0ec
to
96e2463
Compare
Works now - feels a bit strange, and the relatedTarget is marked as experimental, but should work on most browsers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works very nicely now! :)
@nextcloud/accessibility if anyone is interested in giving this another review, please check. :) |
Ooops, conflicts because of another merge again @jotoeri, so sorry about that. :( Luckily the mountain of pull requests is soon scaled. :) |
😅 Arghh. Some code-review would also be good... @juliushaertl maybe? 🙃😊 |
96e2463
to
81d9fa1
Compare
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
81d9fa1
to
fd8f1aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🐘
if (document.activeElement?.parentNode?.classList.contains('question__item--last')) { | ||
this.$nextTick(() => { | ||
if (this.$refs.inputNewAnswer) { | ||
this.$refs.inputNewAnswer.focus() | ||
} | ||
}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I'm really not ok with this kind of code here.
Querying classes is really an anti-pattern to vue apps here as any change have a high risk of getting forgotten.
Break the multiple choice question for me. I will revert this pr I think. |
This one enables to navigate between questions via tab-key and enables edit-mode when entering a question.
Fixes #416 partially, second part for proper navigation on the actions-menu needs to be done on vue (nextcloud-libraries/nextcloud-vue#1126).