Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to webpack vue global config & clean routes #508

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Move to webpack vue global config & clean routes #508

merged 3 commits into from
Jul 14, 2020

Conversation

skjnldsv
Copy link
Member

  • Use the new vue global config
  • Cleanup duplicate routing code
  • Bump necessary deps

@skjnldsv
Move to webpack vue global config & clean routes
7c43e03 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Lint fix
f730c9d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews enhancement New feature or request labels Jul 12, 2020
rullzer
rullzer approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but sure.... 🙈

@skjnldsv
@nextcloud/webpack-vue-config@1.0.3
c7e5d0e 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enh/use-webpack-global-config branch from db872f4 to c7e5d0e Compare July 14, 2020 08:44
@skjnldsv skjnldsv merged commit 769e863 into master Jul 14, 2020
@skjnldsv skjnldsv deleted the enh/use-webpack-global-config branch July 14, 2020 08:47
@Stanislav1975 Stanislav1975 mentioned this pull request Apr 20, 2022
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Jul 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@jotoeri jotoeri Awaiting requested review from jotoeri

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @rullzer