Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden update restrictions #750

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Harden update restrictions #750

merged 1 commit into from
Feb 17, 2021

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Jan 22, 2021

The update procedures allowed for empty arrays, which produced an error on sql then.
Further allowed to change parameters, that shouldn't be changed.

-> This PR blocks corresponding requests on updateForm, updateQuestion and updateOption.

@jotoeri jotoeri added the 3. to review Waiting for reviews label Jan 22, 2021
@jotoeri jotoeri force-pushed the fix/update_restrictions branch 2 times, most recently from 7c91e28 to 45a0e2f Compare January 26, 2021 22:59
@jotoeri jotoeri added this to the 2.2 milestone Jan 30, 2021
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 2663092 into master Feb 17, 2021
@skjnldsv skjnldsv deleted the fix/update_restrictions branch February 17, 2021 11:09
@jotoeri jotoeri added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants