Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export csv to cloud #780

Merged
merged 3 commits into from
Feb 26, 2021
Merged

Export csv to cloud #780

merged 3 commits into from
Feb 26, 2021

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Feb 16, 2021

As i have Onlyoffice meanwhile on my club-instance, i realized how useful it would be to export to cloud directly instead of down- & upload manually.

  • Further included csv-escaping now here, for not to loose it during rebase...

@jotoeri jotoeri added enhancement New feature or request 2. developing Work in progress labels Feb 16, 2021
@codecov-io

This comment has been minimized.

@jotoeri jotoeri force-pushed the enh/export_to_cloud branch 3 times, most recently from d94993c to 8d14a0f Compare February 17, 2021 15:51
@jotoeri jotoeri added 3. to review Waiting for reviews 2. developing Work in progress and removed 2. developing Work in progress 3. to review Waiting for reviews labels Feb 17, 2021
@jotoeri
Copy link
Member Author

jotoeri commented Feb 17, 2021

@jancborchardt

  • Do you have some better wording for the FilePicker Title?
  • It seems to me, i can't avoid people picking files on the file-picker. How would you handle the different cases? Probably show a overwrite-warning, when a file got selected? What i currently do is:
    • If people don't select a file, i just store the file FormName (responses).csv into the folder. If the file exists, i just overwrite. (The data should just be an extended version, why should people change the csv-data without storing it as spreadsheet.)
    • If people select a csv-file, i just overwrite that file.
    • If people select a non-csv-file, i take the folder and write the csv FormName (responses).csv into that folder.

grafik
grafik
grafik

@jotoeri jotoeri marked this pull request as ready for review February 17, 2021 16:09
@jancborchardt
Copy link
Member

Do you have some better wording for the FilePicker Title?

Yup, an improved wording would be "Save CSV to Files" – yes, Files with capital F as it refers to the app – and using the blue icon-folder icon for the action. :)

It seems to me, i can't avoid people picking files on the file-picker. How would you handle the different cases? Probably show a overwrite-warning, when a file got selected?

Yeah, good question – I think the way how you handle the different cases sound good. @skjnldsv what do you think?

And an additional point: Now that we have the new "Save CSV to Files" action, we should rename the "Export to CSV" → "Download CSV"? :)

@jotoeri
Copy link
Member Author

jotoeri commented Feb 22, 2021

Ok - Adapted that. So from my side this is ready to go then... 🎉

grafik
grafik

@jotoeri jotoeri added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 22, 2021
@jotoeri jotoeri force-pushed the enh/export_to_cloud branch 4 times, most recently from 19b0fb9 to 2136098 Compare February 22, 2021 15:37
@jotoeri jotoeri added this to the 2.2 milestone Feb 24, 2021
@jancborchardt
Copy link
Member

Only 1 detail: "Save" instead of "Store". :)

@jotoeri
Copy link
Member Author

jotoeri commented Feb 24, 2021

Oups... Sorry. "Wer lesen kann...." 🙈
Corrected that.

@skjnldsv
Copy link
Member

Rebase please :)

Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri
Copy link
Member Author

jotoeri commented Feb 25, 2021

Done 👍

@skjnldsv skjnldsv merged commit cbed484 into master Feb 26, 2021
@skjnldsv skjnldsv deleted the enh/export_to_cloud branch February 26, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants