Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typed password events #209

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Use typed password events #209

merged 1 commit into from
Nov 27, 2019

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 19, 2019 •
edited
Loading

@ChristophWurst ChristophWurst added enhancement New feature or request 3. to review Waiting for reviews labels Nov 19, 2019
@ChristophWurst ChristophWurst self-assigned this Nov 19, 2019
@ChristophWurst ChristophWurst mentioned this pull request Nov 19, 2019
Merged
1 task
@ChristophWurst ChristophWurst force-pushed the enhancement/typed-password-events branch from 199f0bb to 799e7d4 Compare November 27, 2019 09:54
@ChristophWurst
Use typed password events
d9112b8 
Requires nextcloud/server#18019
Requires nextcloud/password_policy#90

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the enhancement/typed-password-events branch from 799e7d4 to d9112b8 Compare November 27, 2019 10:21
@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 27, 2019
@rullzer rullzer merged commit 7a10e19 into master Nov 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the enhancement/typed-password-events branch November 27, 2019 11:13
skjnldsv
skjnldsv reviewed Nov 27, 2019
View reviewed changes
package.json
@@ -30,6 +30,7 @@
"devDependencies": {
"@babel/core": "^7.7.4",
"@babel/preset-env": "^7.7.4",
"@nextcloud/browserslist-config": "^1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use it? :p

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mimi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it in the rebase of #153

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it because the code wouldn't build otherwise

@skjnldsv
Copy link
Member

skjnldsv commented Nov 27, 2019 •
edited
Loading

  • Requires 18+

🔞 🙈
The true Major release :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv skjnldsv left review comments

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @skjnldsv @rullzer