Fix issue with service selector when running multiple instances #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @tvories :) |
mikaelh
force-pushed
the
fix/support-multiple-instances
branch
from
d91a397
to
b27f998
Compare
|
any update? this is a small fix and non-breaking change @tvories |
Signed-off-by: Mikael Hammarin <mhammarin@ecit.com>
mikaelh
force-pushed
the
fix/support-multiple-instances
branch
2 times, most recently
from
42026d0
to
8e50130
Compare
|
@tvories bumped version number |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikael Hammarin mhammarin@ecit.com
Pull Request
Description of the change
This fix make it possible to run multiple helm instances in the same namespace without traffic accidently being sent to all of them (service selector is not unique per instance).
Benefits
This allow multiple parallel instances of Nextcloud to be run in a single namespace without colliding.
Possible drawbacks
This change make it impossible to lunch multiple deployments which will receive traffic from the same ingress.
However, I can't think of a reason why it would be intended behavior for multiple deployment to use the same service selector.
Applicable issues
NA
Additional information
NA
Checklist
Chart.yamlaccording to semver.