Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: set log level via settings UI #1027

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Feature: set log level via settings UI #1027

merged 2 commits into from
Nov 27, 2023

Conversation

R0Wi
Copy link
Member

@R0Wi R0Wi commented Oct 23, 2023

Resolves: #977

Setting the backend log level is now possible via settings UI. The radiogroup also represents the current loglevel, which is set on the server.

The position of this UI element can be discussed. Maybe it's also worth introducing a new settings button for this.

image

Copy link

github-actions bot commented Nov 7, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

src/components/settings/SettingsSetLogLevel.vue Outdated Show resolved Hide resolved
src/components/settings/SettingsSetLogLevel.vue Outdated Show resolved Hide resolved
src/components/settings/SettingsSetLogLevel.vue Outdated Show resolved Hide resolved
src/components/settings/SettingsSetLogLevel.vue Outdated Show resolved Hide resolved
@susnux
Copy link
Contributor

susnux commented Nov 9, 2023

Nice feature, thank you!
There are some comments, most ones are about indention. You should use tabs instead of spaces.

@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@R0Wi R0Wi force-pushed the feature#977 branch 2 times, most recently from 7c68994 to 11fa9ed Compare November 25, 2023 11:19
@R0Wi
Copy link
Member Author

R0Wi commented Nov 25, 2023

@susnux thanks for your review and sorry for the delayed response. I applied all your suggestions and rebased on the current master. Would love to see your final review 👍

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this :)
I found two things:

  1. Align the default logging level with the one server uses (WARN)
  2. Please validate the given value before setting the system config

lib/Service/SettingsService.php Outdated Show resolved Hide resolved
src/components/settings/SettingsSetLogLevel.vue Outdated Show resolved Hide resolved
src/components/settings/SettingsSetLogLevel.vue Outdated Show resolved Hide resolved
src/store/settings.ts Outdated Show resolved Hide resolved
lib/Controller/SettingsController.php Show resolved Hide resolved
Signed-off-by: Robin Windey <ro.windey@gmail.com>
* Reduce nesting in VUE
* Check value in backend before writing
* Set WARN as default log level
* VUE exception handling with logging

Signed-off-by: GitHub <noreply@github.com>
@R0Wi
Copy link
Member Author

R0Wi commented Nov 27, 2023

@susnux implemented all your requested changes. Thanks again for the nice feedback. Code would now be ready for final reveiw 😄

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you :)

@susnux susnux merged commit 8c10485 into master Nov 27, 2023
21 checks passed
@susnux susnux deleted the feature#977 branch November 27, 2023 17:31
@szaimen
Copy link

szaimen commented Dec 7, 2023

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Set loglevel via UI
4 participants