Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PGP/MIME sending and viewing #10195

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix PGP/MIME sending and viewing #10195

wants to merge 2 commits into from

Conversation

pabzm
Copy link
Contributor

@pabzm pabzm commented Sep 27, 2024

This fixes sending and viewing PGP/MIME encrypted emails (as produced and consumed by Mailvelope in API-mode).

Previously, sent messages were viewable in Mailvelope, too, but all other email programs showed the enclosed mime-headers, because the ciphertext was not properly encapsulated.

Closes #3833 and #9862

@pabzm pabzm force-pushed the fix-pgp-mime branch 9 times, most recently from add510a to 21142f4 Compare October 1, 2024 18:36
@pabzm pabzm self-assigned this Oct 2, 2024
@pabzm pabzm marked this pull request as ready for review October 2, 2024 07:43
@pabzm pabzm requested a review from st3iny October 2, 2024 07:43
@pabzm
Copy link
Contributor Author

pabzm commented Oct 2, 2024

This is now ready for review. I don't know if some changes could be done more elegantly, please give me a hint if so.

@pabzm pabzm linked an issue Oct 2, 2024 that may be closed by this pull request
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Mailvelope and Thunderbird and works. Very nice, thanks!

Please bump the version in appinfo/info.xml to trigger the migration, e.g. 4.1.0-alpha.1.

lib/Db/LocalMessage.php Outdated Show resolved Hide resolved
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sending emails that were encrypted using Mailvelope in API-mode require
a different handling, because the encrypted cleartext contains
MIME-headers.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Provide the ciphertext to the frontend and hand the ciphertext to
Mailvelope.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

Fix sending encrypted messages with Mailvelope Missing PGP/MIME support
2 participants