-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PGP/MIME sending and viewing #10195
base: main
Are you sure you want to change the base?
Conversation
add510a
to
21142f4
Compare
This is now ready for review. I don't know if some changes could be done more elegantly, please give me a hint if so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Mailvelope and Thunderbird and works. Very nice, thanks!
Please bump the version in appinfo/info.xml
to trigger the migration, e.g. 4.1.0-alpha.1
.
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Sending emails that were encrypted using Mailvelope in API-mode require a different handling, because the encrypted cleartext contains MIME-headers. Signed-off-by: Pablo Zmdl <pablo@nextcloud.com> Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Provide the ciphertext to the frontend and hand the ciphertext to Mailvelope. Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
This fixes sending and viewing PGP/MIME encrypted emails (as produced and consumed by Mailvelope in API-mode).
Previously, sent messages were viewable in Mailvelope, too, but all other email programs showed the enclosed mime-headers, because the ciphertext was not properly encapsulated.
Closes #3833 and #9862