Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a database cache for folders #1956

Merged
merged 3 commits into from
Aug 29, 2019
Merged

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Aug 28, 2019

This drastically* speeds up page loads, especially with multi account setups.

Todo

  • Store time of last sync
  • Only sync folders each x hours
  • Update and write tests

*on my two-account test it took an avg of 8s to load a full page (showing a message as well) without this cache and an avg of 4.6 with.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean. I like it.
Also a test run was very promising and smooth. Keep them coming.

lib/Db/Mailbox.php Show resolved Hide resolved
lib/Db/MailAccount.php Show resolved Hide resolved
lib/IMAP/MailboxSync.php Show resolved Hide resolved
lib/IMAP/MailboxSync.php Show resolved Hide resolved
@ChristophWurst ChristophWurst merged commit 81b2e0e into master Aug 29, 2019
@ChristophWurst ChristophWurst deleted the feature/mailbox-cache branch August 29, 2019 13:48
@PriceChild
Copy link

This is brilliant! Makes the app so much more usable. Thanks @ChristophWurst

@ChristophWurst
Copy link
Member Author

Thank you @PriceChild! I really appreciate the feedback!

@ChristophWurst
Copy link
Member Author

We also appreciate ratings on https://apps.nextcloud.com/apps/mail :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants