Refactor imap search #2058
Merged
Refactor imap search #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ChristophWurst
requested review from
rullzer and
kesselb
and removed request for
rullzer
ChristophWurst
force-pushed
the
refactor/imap-search-query-cleanup
branch
from
7c1884b
to
95617c6
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
refactor/imap-search-query-cleanup
branch
from
3481fbf
to
beb06ce
Compare
kesselb
reviewed
Oct 7, 2019
| } | ||
|
|
||
| // TODO: do we still need this fix? | ||
| ob_start(); // fix for Horde warnings |
There was a problem hiding this comment.
Urgh 🙈 Do you know some of these warnings?
There was a problem hiding this comment.
NONE. That is why I added the todo ;)
There was a problem hiding this comment.
It's from 6baf36b. This could be totally useless by know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.