Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show itinerary info #2214

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Conversation

ChristophWurst
Copy link
Member

No description provided.

@jancborchardt
Copy link
Member

jancborchardt commented Dec 2, 2019

Very nice! Only some small issues at the moment:

  • If I click one of the "Plus"-Buttons in a list with multiple itinerary steps, all of them show a spinner
  • The button should ideally not only be a plus but a full "Add to Calendar" button, which in case of multiple calendars shows a popover → we need a component here (follow-up)
  • The min-width is a bit wide, meaning on smartphones stuff overflows to the right. Could be fixed by wrapping the part with the reservation code below the flight name. (Have tried with white-space: CSS but didn’t work?

Otherwise we should really make sure to check with different companies, platforms etc so we make sure we show itinerary info from the most common ones. :)

@ChristophWurst

This comment has been minimized.

@ChristophWurst

This comment has been minimized.

@ChristophWurst
Copy link
Member Author

Otherwise we should really make sure to check with different companies, platforms etc so we make sure we show itinerary info from the most common ones. :)

This is out of scope for us. https://community.kde.org/KDE_PIM/KItinerary/Supported_Providers is the limiting factor here. Anything they support will show up here.

@ChristophWurst

This comment has been minimized.

@ChristophWurst
Copy link
Member Author

3c6c2b7 fixes the issue that the special flagged inbox didn't work before as we tried to open an IMAP mailbox that only virtually exists. @mario you don't know that I know but you ran into this. Props to Sentry for capturing this :)

@ChristophWurst
Copy link
Member Author

* If I click one of the "Plus"-Buttons in a list with multiple itinerary steps, all of them show a spinner

Not reproducible here.

* The min-width is a bit wide, meaning on smartphones stuff overflows to the right. Could be fixed by wrapping the part with the reservation code below the flight name. (Have tried with `white-space:` CSS but didn’t work?

Can be fixed in a follow-up

@StCyr
Copy link
Collaborator

StCyr commented Dec 18, 2019

Don't know how to test this.

I'm guesssing this needs Linux/KDE for it to be effective.

Anyway it builds, upgrade, and runs properly here.

@ChristophWurst
Copy link
Member Author

Don't know how to test this.

I'm guesssing this needs Linux/KDE for it to be effective.

Just open an email with something like a train ticket or flight ticket.

It works out of the box, but not on all systems. If you don't run Linux x86_64 it won't show anything.

Make sure you install composer dependencies with composer install :)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed over the code. Looks good. But I have been using it for some time and does the trick. 🚀

@ChristophWurst ChristophWurst merged commit dd69da9 into master Jan 8, 2020
@ChristophWurst ChristophWurst deleted the feature/kitinerary-integration branch January 8, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants