-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show itinerary info #2214
Show itinerary info #2214
Conversation
528e6c2
to
027f535
Compare
a632e21
to
f247dcf
Compare
Very nice! Only some small issues at the moment:
Otherwise we should really make sure to check with different companies, platforms etc so we make sure we show itinerary info from the most common ones. :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is out of scope for us. https://community.kde.org/KDE_PIM/KItinerary/Supported_Providers is the limiting factor here. Anything they support will show up here. |
This comment has been minimized.
This comment has been minimized.
Not reproducible here.
Can be fixed in a follow-up |
Don't know how to test this. I'm guesssing this needs Linux/KDE for it to be effective. Anyway it builds, upgrade, and runs properly here. |
Just open an email with something like a train ticket or flight ticket. It works out of the box, but not on all systems. If you don't run Linux x86_64 it won't show anything. Make sure you install composer dependencies with |
3c6c2b7
to
7b6c30d
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
7b6c30d
to
150716d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed over the code. Looks good. But I have been using it for some time and does the trick. 🚀
No description provided.