Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save important flag to IMAP if permflags enabled #4593

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Save important flag to IMAP if permflags enabled #4593

merged 1 commit into from
Feb 26, 2021

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Feb 25, 2021 •
edited by ChristophWurst
Loading

Fixes #3069

ToDo:

  • check IMAP capabilities for option permflags = \*
  • set $important flag on server
  • read $important from server
  • tests

Further enhancements:

  • writing the existing flag_important db column entries to server
  • Tagging #25

@miaulalala miaulalala added this to the v1.9 milestone Feb 25, 2021
@miaulalala miaulalala self-assigned this Feb 25, 2021
@miaulalala miaulalala force-pushed the store-importance-flag-on-imap-if-possible branch from c7b5811 to e58c245 Compare February 25, 2021 09:02
kesselb
kesselb approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with my dovecot and permflags enabled.

lib/Listener/NewMessageClassificationListener.php Show resolved Hide resolved
lib/Service/MailManager.php Outdated Show resolved Hide resolved
lib/Service/MailManager.php Outdated Show resolved Hide resolved
st3iny
st3iny approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested on my local dev instance with permflags support and it works well.

lib/Service/MailManager.php Outdated Show resolved Hide resolved
@miaulalala miaulalala mentioned this pull request Feb 26, 2021
Closed
8 tasks
@miaulalala miaulalala force-pushed the store-importance-flag-on-imap-if-possible branch 2 times, most recently from c7f8919 to b1eefe2 Compare February 26, 2021 11:37
ChristophWurst
ChristophWurst approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out both of my test accounts do actually support permflags :/

So sadly I couldn't break your changes :P

@miaulalala
Save important flag to IMAP if permflags enabled
4cc2dd7 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the store-importance-flag-on-imap-if-possible branch from b1eefe2 to 4cc2dd7 Compare February 26, 2021 13:45
@ChristophWurst ChristophWurst merged commit 685580f into master Feb 26, 2021
@ChristophWurst ChristophWurst deleted the store-importance-flag-on-imap-if-possible branch February 26, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny st3iny approved these changes

@kesselb kesselb kesselb approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@StCyr StCyr Awaiting requested review from StCyr

Assignees

@miaulalala miaulalala

Labels
3. to review enhancement
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Store importance flag on IMAP, if possible
4 participants
@miaulalala @ChristophWurst @st3iny @kesselb