Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snooze): create snooze mailbox on first snooze #8771

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

JohannesGGE
Copy link
Contributor

@JohannesGGE JohannesGGE commented Aug 17, 2023

Fix: #8742

Creates a new "Snoozed" mailbox and select it as dedicated snooze mailbox. If a mailbox "Snoozed" already exists, this mailbox ist selected.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace .then with awaits please

@JohannesGGE JohannesGGE force-pushed the fix/8742/create-snooze-on-first-snooze branch from 4fc009a to f3e2487 Compare August 17, 2023 18:03
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the logic into a Vuex action to deduplicate the two code fragments

👍 then

src/components/Envelope.vue Outdated Show resolved Hide resolved
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
@JohannesGGE JohannesGGE force-pushed the fix/8742/create-snooze-on-first-snooze branch from f3e2487 to d38e426 Compare August 17, 2023 21:18
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JohannesGGE JohannesGGE merged commit 71a082d into main Aug 18, 2023
27 of 28 checks passed
@JohannesGGE JohannesGGE deleted the fix/8742/create-snooze-on-first-snooze branch August 18, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Snooze Mailbox on first Snooze
2 participants