Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/dynamite/prepare_httpclient_request_flow #1689

Merged
merged 7 commits into from
Mar 2, 2024

Conversation

Leptopoda
Copy link
Member

refactors extracted from: #1580
Motivation:
This decouples the resolving and generation of our parameter code.
The new code first resolves everything into a collections that can later be used to generate code.

      final operationParameters = <Parameter>[];
      final pathParameters = <openapi.Parameter, TypeResult>{};
      final headerParameters = <openapi.Parameter, TypeResult>{};

This is needed to keep further behavior changing changes easy to review.

@Leptopoda Leptopoda force-pushed the refactor/dynamite/prepare_httpclient_request_flow branch from 824129e to d3c0cbc Compare March 1, 2024 19:09
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

Typo in the commit message: refactor(dynamite): split mimetiype resolving and parameter generation should be refactor(dynamite): split mimetype resolving and parameter generation

Thanks for splitting this up very nicely.

Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
@Leptopoda Leptopoda force-pushed the refactor/dynamite/prepare_httpclient_request_flow branch from d3c0cbc to afdb084 Compare March 2, 2024 13:29
@Leptopoda Leptopoda merged commit b8bf340 into main Mar 2, 2024
8 checks passed
@Leptopoda Leptopoda deleted the refactor/dynamite/prepare_httpclient_request_flow branch March 2, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants