feat(dynamite): use http.Request in generated code #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leptopoda
force-pushed
the
feat/dynamite/dynamite_request
branch
from
d8ed838
to
0add5dc
Compare
|
Shouldn't it be possible now to put the serializer into the request? Or do you think that mixes the layers too much? |
|
Do you mean similar to the validStatuses? I think this is to much mixing. Although I have to admit that the validStatuses shouldn't be there either |
|
Yeah, and I somewhat agree that the validation should not be in the request. |
|
So should we move the status code matching into the serializer? |
|
This might also make sense long term if we want to allow different response schemas per status code. |
|
That sounds good and should help with supporting multiple status codes 👍 |
Leptopoda
force-pushed
the
feat/dynamite/dynamite_request
branch
from
0add5dc
to
3ae463d
Compare
provokateurin
requested changes
Mar 8, 2024
Leptopoda
force-pushed
the
feat/dynamite/dynamite_request
branch
from
3ae463d
to
f6e60fd
Compare
Leptopoda
force-pushed
the
feat/dynamite/dynamite_request
branch
from
f6e60fd
to
2f307d1
Compare
Leptopoda
changed the title
provokateurin
requested changes
Mar 9, 2024
Leptopoda
force-pushed
the
feat/dynamite/dynamite_request
branch
from
2f307d1
to
26917bd
Compare
provokateurin
approved these changes
Mar 9, 2024
Leptopoda
force-pushed
the
feat/dynamite/dynamite_request
branch
from
26917bd
to
d3b6cfa
Compare
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Leptopoda
force-pushed
the
feat/dynamite/dynamite_request
branch
from
d3b6cfa
to
c9d0b24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last remaining piece of #1580