-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use vue-richtext instead of handlebars #727
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
- along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
--> | ||
|
||
<template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For later we could also have those in a library, since they would be reusable then for any ui that uses the rich object string definitions from the server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, specially the empty default would be nice I guess.
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@@ -141,73 +162,74 @@ export default { | |||
return (new Date(this.datetime)).valueOf() | |||
}, | |||
absoluteDate: function() { | |||
return OC.Util.formatDate(this.timestamp) | |||
return OC.Util.formatDate(this.timestamp, 'LLL') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OC.Util.formatDate is deprecated and will be removed in Nextcloud 21. See @nextcloud/moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small deprecation comment but fine to tackle that in a separate pr of course. Otherwise 👍
Fix #412
Fix #427