Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update README #642

Merged
merged 2 commits into from
Aug 20, 2024
Merged

chore: Update README #642

merged 2 commits into from
Aug 20, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 19, 2024

  1. Fix broken screenshot
  2. Add basic information for usage (old example was using the wrong event)
  3. Adjust REUSE information
before after
Screenshot 2024-08-19 at 18-17-58 nextcloud_password_policy lock Let the admin define certain rules for passwords e g  a minimum length Screenshot 2024-08-19 at 18-20-47 nextcloud_password_policy at susnux-patch-1

Add basic usage information and update broken screenshot

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Aug 20, 2024

exclamation mark is not needed since this doesn't get compiled to an asset :)

I will fix this, but I personally prefer the "license" notation /*! because the /** notation is considered documentation.
Here it does not make a difference, but if you generate code documentation the SPDX-... would be considered the documentation for the class 😅

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 954bfdb into master Aug 20, 2024
46 checks passed
@susnux susnux deleted the susnux-patch-1 branch August 20, 2024 11:32
@come-nc
Copy link
Contributor

come-nc commented Aug 20, 2024

exclamation mark is not needed since this doesn't get compiled to an asset :)

I will fix this, but I personally prefer the "license" notation /*! because the /** notation is considered documentation. Here it does not make a difference, but if you generate code documentation the SPDX-... would be considered the documentation for the class 😅

What about /*?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants