Merge pull request #2190 from nextcloud/fix/a11y-favorite

fix: Adjust favorite icon to be accessible
nextcloud · Dec 13, 2023 · dabd93e · dabd93e
2 parents 9f73a6a + 5bb7b9f
commit dabd93e
Show file tree

Hide file tree

Showing 38 changed files with 151 additions and 66 deletions.
diff --git a/cypress/e2e/albums.cy.js b/cypress/e2e/albums.cy.js
@@ -85,20 +85,20 @@ describe('Manage albums', () => {
 	it('Favorite a file from an album content view', () => {
 		selectMedia([0])
 		favoriteSelection()
-		cy.get('[data-test="media"]').eq(0).find('[aria-label="The file is in the favorites"]')
+		cy.get('[data-test="media"]').eq(0).find('[aria-label="Favorite"]')
 		unfavoriteSelection()
 		unselectMedia([0])
-		cy.get('[aria-label="The file is in the favorites"]').should('not.exist')
+		cy.get('[aria-label="Favorite"]').should('not.exist')
 	})
 
 	it('Favorite multiple files from an album content view', () => {
 		selectMedia([1, 2])
 		favoriteSelection()
-		cy.get('[data-test="media"]').eq(1).find('[aria-label="The file is in the favorites"]')
-		cy.get('[data-test="media"]').eq(2).find('[aria-label="The file is in the favorites"]')
+		cy.get('[data-test="media"]').eq(1).find('[aria-label="Favorite"]')
+		cy.get('[data-test="media"]').eq(2).find('[aria-label="Favorite"]')
 		unfavoriteSelection()
 		unselectMedia([1, 2])
-		cy.get('[aria-label="The file is in the favorites"]').should('not.exist')
+		cy.get('[aria-label="Favorite"]').should('not.exist')
 	})
 
 	// it('Download a file from an album content view', () => {

diff --git a/cypress/e2e/timelines.cy.js b/cypress/e2e/timelines.cy.js
@@ -74,20 +74,20 @@ describe('View list of photos in the main timeline', () => {
 	it('Favorite a file from a timeline', () => {
 		selectMedia([0])
 		favoriteSelection()
-		cy.get('[data-test="media"]').eq(0).find('[aria-label="The file is in the favorites"]')
+		cy.get('[data-test="media"]').eq(0).find('[aria-label="Favorite"]')
 		unfavoriteSelection()
 		unselectMedia([0])
-		cy.get('[aria-label="The file is in the favorites"]').should('not.exist')
+		cy.get('[aria-label="Favorite"]').should('not.exist')
 	})
 
 	it('Favorite multiple files from a timeline', () => {
 		selectMedia([1, 2])
 		favoriteSelection()
-		cy.get('[data-test="media"]').eq(1).find('[aria-label="The file is in the favorites"]')
-		cy.get('[data-test="media"]').eq(2).find('[aria-label="The file is in the favorites"]')
+		cy.get('[data-test="media"]').eq(1).find('[aria-label="Favorite"]')
+		cy.get('[data-test="media"]').eq(2).find('[aria-label="Favorite"]')
 		unfavoriteSelection()
 		unselectMedia([1, 2])
-		cy.get('[aria-label="The file is in the favorites"]').should('not.exist')
+		cy.get('[aria-label="Favorite"]').should('not.exist')
 	})
 
 	it('Download a file from a timeline', () => {

diff --git a/js/photos-main.js b/js/photos-main.js
diff --git a/js/photos-main.js.map b/js/photos-main.js.map
diff --git a/...les_vue-material-design-icons_P-fb52a0.js → ...les_vue-material-design-icons_P-3c3243.js b/...les_vue-material-design-icons_P-fb52a0.js → ...les_vue-material-design-icons_P-3c3243.js
diff --git a/...rial-design-icons_P-64264b.js.LICENSE.txt → ...rial-design-icons_P-3c3243.js.LICENSE.txt b/...rial-design-icons_P-64264b.js.LICENSE.txt → ...rial-design-icons_P-3c3243.js.LICENSE.txt
diff --git a/...aterial-design-icons_ArrowLeft_vue-node_modules_vue-material-design-icons_P-3c3243.js.map b/...aterial-design-icons_ArrowLeft_vue-node_modules_vue-material-design-icons_P-3c3243.js.map
diff --git a/...aterial-design-icons_ArrowLeft_vue-node_modules_vue-material-design-icons_P-64264b.js.map b/...aterial-design-icons_ArrowLeft_vue-node_modules_vue-material-design-icons_P-64264b.js.map
diff --git a/...les_vue-material-design-icons_P-64264b.js → ...les_vue-material-design-icons_P-e1736f.js b/...les_vue-material-design-icons_P-64264b.js → ...les_vue-material-design-icons_P-e1736f.js
diff --git a/...rial-design-icons_P-fb52a0.js.LICENSE.txt → ...rial-design-icons_P-e1736f.js.LICENSE.txt b/...rial-design-icons_P-fb52a0.js.LICENSE.txt → ...rial-design-icons_P-e1736f.js.LICENSE.txt
diff --git a/...aterial-design-icons_ArrowLeft_vue-node_modules_vue-material-design-icons_P-e1736f.js.map b/...aterial-design-icons_ArrowLeft_vue-node_modules_vue-material-design-icons_P-e1736f.js.map
diff --git a/...aterial-design-icons_ArrowLeft_vue-node_modules_vue-material-design-icons_P-fb52a0.js.map b/...aterial-design-icons_ArrowLeft_vue-node_modules_vue-material-design-icons_P-fb52a0.js.map
diff --git a/js/photos-node_modules_vue-material-design-icons_ArrowLeft_vue-src_views_Timeline_vue.js b/js/photos-node_modules_vue-material-design-icons_ArrowLeft_vue-src_views_Timeline_vue.js
diff --git a/js/photos-node_modules_vue-material-design-icons_ArrowLeft_vue-src_views_Timeline_vue.js.map b/js/photos-node_modules_vue-material-design-icons_ArrowLeft_vue-src_views_Timeline_vue.js.map
diff --git a/...ue-material-design-icons_PackageVariant_vue-node_modules_vue-material-design-ic-156f2a.js b/...ue-material-design-icons_PackageVariant_vue-node_modules_vue-material-design-ic-156f2a.js
diff --git a/...aterial-design-icons_PackageVariant_vue-node_modules_vue-material-design-ic-156f2a.js.map b/...aterial-design-icons_PackageVariant_vue-node_modules_vue-material-design-ic-156f2a.js.map
diff --git a/...aterial-design-icons_PackageVariant_vue-node_modules_vue-material-design-ic-393f33.js.map b/...aterial-design-icons_PackageVariant_vue-node_modules_vue-material-design-ic-393f33.js.map
diff --git a/..._modules_vue-material-design-ic-393f33.js → ..._modules_vue-material-design-ic-7ffa74.js b/..._modules_vue-material-design-ic-393f33.js → ..._modules_vue-material-design-ic-7ffa74.js
diff --git a/...-material-design-ic-393f33.js.LICENSE.txt → ...-material-design-ic-7ffa74.js.LICENSE.txt b/...-material-design-ic-393f33.js.LICENSE.txt → ...-material-design-ic-7ffa74.js.LICENSE.txt
diff --git a/...aterial-design-icons_PackageVariant_vue-node_modules_vue-material-design-ic-7ffa74.js.map b/...aterial-design-icons_PackageVariant_vue-node_modules_vue-material-design-ic-7ffa74.js.map
diff --git a/..._modules_vue-material-design-ic-b86cef.js → ..._modules_vue-material-design-ic-88a20b.js b/..._modules_vue-material-design-ic-b86cef.js → ..._modules_vue-material-design-ic-88a20b.js
diff --git a/...ules_vue-material-design-ic-b86cef.js.map → ...ules_vue-material-design-ic-88a20b.js.map b/...ules_vue-material-design-ic-b86cef.js.map → ...ules_vue-material-design-ic-88a20b.js.map