Improve overall preview loading #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
artonge
added
3. to review
artonge
force-pushed
the
artonge/feat/optimize_preview_rendering
branch
from
570117a
to
fbaea8b
Compare
artonge
commented
Feb 23, 2023
| @@ -122,7 +122,7 @@ function genFileInfo(obj) { | |||
|
|
|||
| if (fileInfo.filename) { | |||
| // Adding context | |||
| fileInfo.source = generateRemoteUrl(rootPath) + '/' + encodeFilePath(fileInfo.filename) | |||
| fileInfo.source = generateRemoteUrl(rootPath) + encodeFilePath(fileInfo.filename) | |||
There was a problem hiding this comment.
This was making the editor to emit the wrong event as there was a duplicate //
https://github.com/nextcloud/viewer/blob/0931d2e08f630fe0748e807db427f8933cca3dbc/src/components/ImageEditor.vue#L174
artonge
requested review from
skjnldsv,
a team,
Pytal and
szaimen
and removed request for
a team
skjnldsv
approved these changes
Feb 23, 2023
Pytal
approved these changes
Feb 24, 2023
This PR improve on the logic to display previews: 1. Append the etag of the file to the file request. This ensure that old cache will not be used if the image is updated 2. Listen to 'files:file:updated' to refetch the file's info and have the new etag 3. Distinguish onload and on error events of the small and large previews to have a finer rendering conditions. Mostly not rendering both previews if the larger one is loaded. 4. Do not delay rendering of files to make the UI snappier Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/feat/optimize_preview_rendering
branch
from
fbaea8b
to
5f47922
Compare
backportbot-nextcloud
bot
added
the
backport-request
1 task
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improve on the logic to display previews: