Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account cropped layout setting #1659

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Take into account cropped layout setting #1659

merged 1 commit into from
Feb 28, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Feb 27, 2023 •
edited
Loading

Need a reload to be taken into account. But still better than nothing.

Before After
Screenshot 2023-02-27 at 18-29-28 Photos - Nextcloud Screenshot 2023-02-27 at 18-29-18 Photos - Nextcloud

@artonge artonge added 3. to review Waiting for reviews regression Regression of a previous working feature javascript Javascript related ticket labels Feb 27, 2023
@artonge artonge added this to the Nextcloud 26 milestone Feb 27, 2023
@artonge artonge self-assigned this Feb 27, 2023
@artonge artonge force-pushed the artonge/fix/use_cropped_layout_info branch from c3b04bc to 68fd74b Compare February 27, 2023 17:18
@artonge artonge force-pushed the artonge/fix/use_cropped_layout_info branch from 68fd74b to 24fab37 Compare February 27, 2023 17:27
ChristophWurst
ChristophWurst approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

Can't test because previews don't work on my dev env

jancborchardt
jancborchardt approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@artonge
Take into account cropped layout setting
d887817 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/use_cropped_layout_info branch from 24fab37 to d887817 Compare February 28, 2023 09:45
@artonge artonge merged commit 40f3e2e into master Feb 28, 2023
@artonge artonge deleted the artonge/fix/use_cropped_layout_info branch February 28, 2023 10:04
@simonspa simonspa mentioned this pull request Feb 28, 2023
Closed
@ChristophWurst
Copy link
Member

Would you consider this a fix and backportable?

@artonge
Copy link
Collaborator Author

artonge commented Mar 1, 2023

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Mar 1, 2023
@artonge
Copy link
Collaborator Author

artonge commented Mar 1, 2023

Let's try :)

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 1, 2023
Merged
1 task
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Mar 1, 2023
@blizzz blizzz mentioned this pull request Mar 2, 2023
Merged
@danxuliu danxuliu mentioned this pull request Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews javascript Javascript related ticket regression Regression of a previous working feature
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @ChristophWurst @jancborchardt @skjnldsv