[stable25] fix(settings): Debounce filepicker calls #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
artonge,
ChristophWurst and
hamza221
|
/compile amend / |
The filepicker falls apart when you open it twice in less than 200ms. That is because the filepicker closes any previous instance when it opens, and closing logic delayed by 200ms. It happens like 1) Open file picker 1 2) Open file picker 2 -> trigger destruction of fp1, continue fp2 initialization 3) fp2 destruction is finished, but the reference now points to fp1 -> fp1 gets destroyed By adding debounce we can make sure focus+click do not cause a doubly opened filepicker and the bug described above. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
backport/1709/stable25
branch
from
9f8443e
to
29959ad
Compare
ChristophWurst
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1709