Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1753: Media and Photos views are blank after upgrade to 26.0.1 #1757

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

umgfoin
Copy link
Contributor

@umgfoin umgfoin commented Apr 22, 2023

Handle empty fileMetadataSize.
Fixes #1753.

@umgfoin umgfoin added 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Apr 22, 2023
@umgfoin umgfoin requested a review from artonge April 22, 2023 16:25
@umgfoin umgfoin force-pushed the PR_Fix_#1753 branch 2 times, most recently from b071f6b to f7cf327 Compare April 22, 2023 17:26
@umgfoin umgfoin requested a review from skjnldsv April 22, 2023 17:35
@szaimen szaimen added this to the Nextcloud 27 milestone Apr 22, 2023
@szaimen szaimen removed the 4. to release Ready to be released and/or waiting for tests to finish label Apr 22, 2023
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@artonge
Copy link
Collaborator

artonge commented Apr 24, 2023

/compile amend /

@artonge
Copy link
Collaborator

artonge commented Apr 24, 2023

Thanks, looks good :) 👍

@artonge artonge enabled auto-merge April 24, 2023 07:55
Handle empty fileMetadataSize.

Signed-off-by: umgfoin <umgfoin@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge merged commit 1c56305 into master Apr 24, 2023
@artonge artonge deleted the PR_Fix_#1753 branch April 24, 2023 08:05
@szaimen
Copy link
Contributor

szaimen commented Apr 24, 2023

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Apr 24, 2023
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Apr 24, 2023
@DaleBCooper
Copy link

This breaks the "Folder" view.
See: #1759 (comment)

@artonge
Copy link
Collaborator

artonge commented May 9, 2023

Might be fixed by #1779

@DaleBCooper
Copy link

This looks good! #1779 fixed it for me.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All Media and Photos views are blank after upgrade to 26.0.1
5 participants