Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fatal Error in Album setCollaborator function - redefining computeKey function #2205

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

frederikb96
Copy link
Contributor

When calling setCollaborator function two times after another, computeKey is redefined and leads to a fatal error. Fixed by defining it as an anonymous function instead :)

I wrote an app, which calls this function, and thus I discovered that problem.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@artonge
Copy link
Collaborator

artonge commented Jan 24, 2024

Thanks @frederikb96, can you fix the DCO?

@frederikb96
Copy link
Contributor Author

Thanks, I will look into it tomorrow 🙂

@frederikb96
Copy link
Contributor Author

@artonge Ok, I guess that's it right (I am new to this :)), thanks.

@artonge
Copy link
Collaborator

artonge commented Jan 25, 2024

@frederikb96 Php cs is also red. Running php run cs:fix should be enough.
Cypress tests failure seem unrelated. :)

…eKey

When calling setCollaborator function two times after another, computeKey is redefined and leads to a fatal error. Fixed by defining it as an anonymous function instead :)

Signed-off-by: Frederik Berg <83548283+frederikb96@users.noreply.github.com>
@frederikb96
Copy link
Contributor Author

@frederikb96 Php cs is also red. Running php run cs:fix should be enough. Cypress tests failure seem unrelated. :)

@artonge Ok php cs is fixed now :)

@artonge artonge merged commit 3d93169 into nextcloud:master Jan 25, 2024
29 checks passed
@artonge
Copy link
Collaborator

artonge commented Jan 25, 2024

Thanks a lot @frederikb96 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants