Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also sort by getlastmodified when searching for photos #2226

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jan 2, 2024

Fix #2195

@artonge
Copy link
Collaborator Author

artonge commented Jan 2, 2024

/backport to stable28

@artonge artonge self-assigned this Jan 2, 2024
@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jan 2, 2024
@artonge artonge requested a review from skjnldsv January 2, 2024 14:54
@artonge artonge added this to the Nextcloud 29 milestone Jan 2, 2024
@artonge artonge force-pushed the artonge/fix/search_on_files_without_metadata branch from a1a157f to 573fc9a Compare January 2, 2024 15:07
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Jan 2, 2024
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many dist changes for one src edit 🙈

@artonge
Copy link
Collaborator Author

artonge commented Jan 2, 2024

/compile amend /

@nextcloud-command nextcloud-command force-pushed the artonge/fix/search_on_files_without_metadata branch from 573fc9a to fa518b3 Compare January 2, 2024 16:25
@skjnldsv
Copy link
Member

skjnldsv commented Jan 2, 2024

/compile amend /

tips&trick: NOT using amend allows you to backport the commit afterwards btw

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/search_on_files_without_metadata branch from fa518b3 to 1f1c54a Compare January 2, 2024 16:50
@artonge
Copy link
Collaborator Author

artonge commented Jan 2, 2024

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge merged commit dd266f2 into master Jan 2, 2024
23 checks passed
@artonge artonge deleted the artonge/fix/search_on_files_without_metadata branch January 2, 2024 19:53
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@artonge
Copy link
Collaborator Author

artonge commented Jan 2, 2024

/backport 1f1c54a to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete results on loading up latest version
3 participants