fix: Fix focus loop on tab navigation in Add to album modal + Migrate to new UploadPicker API #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Pytal
force-pushed
the
fix/a11y/focus-trap-add-to-album
branch
from
45fae76
to
2b11e70
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
artonge
force-pushed
the
fix/a11y/focus-trap-add-to-album
branch
from
a9b779b
to
46629ca
Compare
This comment was marked as resolved.
This comment was marked as resolved.
artonge
force-pushed
the
fix/a11y/focus-trap-add-to-album
branch
from
46629ca
to
1ef4806
Compare
Pytal
force-pushed
the
fix/a11y/focus-trap-add-to-album
branch
from
1ef4806
to
15ae2a9
Compare
Pytal
changed the title
Pytal
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Christopher Ng <chrng8@gmail.com>
artonge
force-pushed
the
fix/a11y/focus-trap-add-to-album
branch
from
15ae2a9
to
14624d3
Compare
artonge
approved these changes
Jan 30, 2024
Pytal
force-pushed
the
fix/a11y/focus-trap-add-to-album
branch
from
14624d3
to
a5a0668
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Pytal
added
4. to release
Pytal
force-pushed
the
fix/a11y/focus-trap-add-to-album
branch
from
af706d4
to
74152a6
Compare
|
/compile amend / |
Pytal
changed the title
|
/backport to stable28 |
nextcloud-command
force-pushed
the
fix/a11y/focus-trap-add-to-album
branch
from
74152a6
to
958318c
Compare
Pytal
force-pushed
the
fix/a11y/focus-trap-add-to-album
branch
from
958318c
to
5029447
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Pytal
force-pushed
the
fix/a11y/focus-trap-add-to-album
branch
from
5029447
to
0a25bfc
Compare
2 tasks
backportbot
bot
removed
the
backport-request
|
Great that it works! Thanks Chris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary