Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase spacing to bottom for sidebar button #237

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 4, 2023

Before After
Screenshot from 2023-08-04 18-35-47 Screenshot from 2023-08-04 18-36-23

@kesselb kesselb added enhancement New feature or request 3. to review labels Aug 4, 2023
@kesselb kesselb self-assigned this Aug 4, 2023
Copy link

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one missing new line for stylelint

@@ -413,4 +413,8 @@ export default {
// overwrite body height for profiler toolbar
--body-height: calc(100% - env(safe-area-inset-bottom) - 50px - var(--body-container-margin) - 36px);
}
.app-sidebar-tab__buttons {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.app-sidebar-tab__buttons {
.app-sidebar-tab__buttons {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run stylelint:fix did the trick 🎉

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb merged commit f4bbac9 into master Aug 17, 2023
14 checks passed
@kesselb kesselb deleted the profiler-sidebar-button branch August 17, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants