Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): Bump nextcloud/coding-standard from 1.1.1 to 1.2.1 #322

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/DataCollector/EventLoggerDataProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public function __construct(IEventLogger $eventLogger) {
$this->eventLogger = $eventLogger;
}

public function collect(Request $request, Response $response, \Throwable $exception = null): void {
public function collect(Request $request, Response $response, ?\Throwable $exception = null): void {
$this->data = [];
foreach ($this->eventLogger->getEvents() as $event) {
$this->data[$event->getId()] = [
Expand Down
2 changes: 1 addition & 1 deletion lib/DataCollector/HttpDataCollector.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public function getName(): string {
return 'http';
}

public function collect(Request $request, Response $response, \Throwable $exception = null): void {
public function collect(Request $request, Response $response, ?\Throwable $exception = null): void {
try {
$content = $request->getParams();
} catch (\THrowable $ex) {
Expand Down
4 changes: 2 additions & 2 deletions lib/DataCollector/MemoryDataCollector.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function getName(): string {
return 'memory';
}

public function collect(Request $request, Response $response, \Throwable $exception = null): void {
public function collect(Request $request, Response $response, ?\Throwable $exception = null): void {
$this->data = [
'memory' => memory_get_peak_usage(true),
'memory_limit' => $this->convertToBytes(ini_get('memory_limit')),
Expand All @@ -39,7 +39,7 @@ public function getMemoryLimit() {
* @return int|float
*/
private function convertToBytes(string $memoryLimit) {
if ('-1' === $memoryLimit) {
if ($memoryLimit === '-1') {
return -1;
}

Expand Down
2 changes: 1 addition & 1 deletion tests/stubs/oc_core_command_base.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class Base {

protected string $defaultOutputFormat = self::OUTPUT_FORMAT_PLAIN;

public function __construct(string $name = null) {
public function __construct(?string $name = null) {
}

protected function configure() {
Expand Down
Loading