-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
richdocuments: add host_session_id parameter #3763
Conversation
Can you provide some context on what this is used? In addition you can already get the richdocuments version in the frontend code through the capabilities so no backend changes should be required and please also add it to richdocuments/src/view/Office.vue Line 51 in e9ec318
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs mentioned adjustments
Thanks, it is mostly to implement Wopi HOST_SESSION_ID, to debugging log purposes and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs to also be added in
richdocuments/src/view/Office.vue
Line 51 in e9ec318
<input name="access_token" :value="formData.accessToken" type="hidden"> |
"This helps for the web engineers more quickly find logs for troubleshooting purposes based on a host-specific session identifier". Signed-off-by: Henry Castro <hcastro@collabora.com>
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
TODO
Checklist