Merge pull request #43334 from nextcloud/fix/array-access-on-boolean

fix(settings): `posix_getpwuid` can return `false` which should not be accessed like an array
nextcloud · Mar 13, 2024 · 078f51b · 078f51b
2 parents 5ea10a0 + 002fda6
commit 078f51b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/apps/settings/lib/Settings/Admin/Server.php b/apps/settings/lib/Settings/Admin/Server.php
@@ -56,13 +56,17 @@ public function __construct(
 	 * @return TemplateResponse
 	 */
 	public function getForm() {
+		$ownerConfigFile = fileowner(\OC::$configDir . 'config.php');
+		$cliBasedCronPossible = function_exists('posix_getpwuid') && $ownerConfigFile !== false;
+		$cliBasedCronUser = $cliBasedCronPossible ? (posix_getpwuid($ownerConfigFile)['name'] ?? '') : '';
+
 		// Background jobs
 		$this->initialStateService->provideInitialState('backgroundJobsMode', $this->config->getAppValue('core', 'backgroundjobs_mode', 'ajax'));
 		$this->initialStateService->provideInitialState('lastCron', $this->appConfig->getValueInt('core', 'lastcron', 0));
 		$this->initialStateService->provideInitialState('cronMaxAge', $this->cronMaxAge());
 		$this->initialStateService->provideInitialState('cronErrors', $this->config->getAppValue('core', 'cronErrors'));
-		$this->initialStateService->provideInitialState('cliBasedCronPossible', function_exists('posix_getpwuid'));
-		$this->initialStateService->provideInitialState('cliBasedCronUser', function_exists('posix_getpwuid') ? posix_getpwuid(fileowner(\OC::$configDir . 'config.php'))['name'] : '');
+		$this->initialStateService->provideInitialState('cliBasedCronPossible', $cliBasedCronPossible);
+		$this->initialStateService->provideInitialState('cliBasedCronUser', $cliBasedCronUser);
 		$this->initialStateService->provideInitialState('backgroundJobsDocUrl', $this->urlGenerator->linkToDocs('admin-background-jobs'));
 
 		// Profile page