Merge pull request #42062 from nextcloud/use-href-for-search-results

Correct semantics for link opening in global search
nextcloud · Dec 6, 2023 · 0eadd0d · 0eadd0d
2 parents add1758 + eb90cd0
commit 0eadd0d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/core/src/components/GlobalSearch/SearchResult.vue b/core/src/components/GlobalSearch/SearchResult.vue
@@ -2,7 +2,8 @@
 	<NcListItem class="result-items__item"
 		:name="title"
 		:bold="false"
-		@click="openResult(resourceUrl)">
+		:href="resourceUrl"
+		target="_self">
 		<template #icon>
 			<div aria-hidden="true"
 				class="result-items__item-icon"
@@ -91,11 +92,6 @@ export default {
 		thumbnailErrorHandler() {
 			this.thumbnailHasError = true
 		},
-		openResult(url) {
-			if (url) {
-				window.location = url
-			}
-		},
 	},
 }
 </script>

diff --git a/dist/core-global-search.js b/dist/core-global-search.js
diff --git a/dist/core-global-search.js.map b/dist/core-global-search.js.map