Skip to content

Commit

Permalink
Adapt "advanced settings" button for accordion button
Browse files Browse the repository at this point in the history
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
  • Loading branch information
JuliaKirschenheuter committed Nov 14, 2023
1 parent e90df64 commit 1f3a7ec
Show file tree
Hide file tree
Showing 13 changed files with 46 additions and 342 deletions.
14 changes: 12 additions & 2 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,20 @@
</div>
<div class="sharingTabDetailsView__advanced-control">
<NcButton type="tertiary"
id="advancedSectionAccordionAdvancedControl"
alignment="end-reverse"
aria-controls="advancedSectionAccordionAdvanced"
:aria-expanded="advancedControlExpandedValue"
@click="advancedSectionAccordionExpanded = !advancedSectionAccordionExpanded">
{{ t('files_sharing', 'Advanced settings') }}
<template #icon>
<MenuDownIcon />
<MenuDownIcon v-if="!advancedSectionAccordionExpanded" />
<MenuUpIcon v-else />
</template>
</NcButton>
</div>
<div v-if="advancedSectionAccordionExpanded" class="sharingTabDetailsView__advanced">
<div v-if="advancedSectionAccordionExpanded" id="advancedSectionAccordionAdvanced" class="sharingTabDetailsView__advanced"
aria-labelledby="advancedSectionAccordionAdvancedControl" role="region">
<section>
<NcInputField v-if="isPublicShare"
:value.sync="share.label"
Expand Down Expand Up @@ -226,6 +231,7 @@ import UserIcon from 'vue-material-design-icons/AccountCircleOutline.vue'
import ViewIcon from 'vue-material-design-icons/Eye.vue'
import UploadIcon from 'vue-material-design-icons/Upload.vue'
import MenuDownIcon from 'vue-material-design-icons/MenuDown.vue'
import MenuUpIcon from 'vue-material-design-icons/MenuUp.vue'
import DotsHorizontalIcon from 'vue-material-design-icons/DotsHorizontal.vue'
import GeneratePassword from '../utils/GeneratePassword.js'
Expand Down Expand Up @@ -260,6 +266,7 @@ export default {
UploadIcon,
ViewIcon,
MenuDownIcon,
MenuUpIcon,
DotsHorizontalIcon,
},
mixins: [ShareTypes, ShareRequests, SharesMixin],
Expand Down Expand Up @@ -644,6 +651,9 @@ export default {
: translatedPermissions[permission].toLocaleLowerCase(getLanguage()))
.join(', ')
},
advancedControlExpandedValue() {
return this.advancedSectionAccordionExpanded ? 'true' : 'false'
}
},
watch: {
setCustomPermissions(isChecked) {
Expand Down
3 changes: 0 additions & 3 deletions dist/6329-6329.js

This file was deleted.

324 changes: 0 additions & 324 deletions dist/6329-6329.js.LICENSE.txt

This file was deleted.

1 change: 0 additions & 1 deletion dist/6329-6329.js.map

This file was deleted.

4 changes: 2 additions & 2 deletions dist/core-common.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-common.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/files-main.js

Large diffs are not rendered by default.

Loading

0 comments on commit 1f3a7ec

Please sign in to comment.