Ensure the user exists before calling a method on it - fixes #24751

nextcloud · Aug 14, 2016 · 2634206 · 2634206
1 parent 241fc28
commit 2634206
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/lib/private/legacy/util.php b/lib/private/legacy/util.php
@@ -165,6 +165,7 @@ public static function setupFS($user = '') {
 
 		// install storage availability wrapper, before most other wrappers
 		\OC\Files\Filesystem::addStorageWrapper('oc_availability', function ($mountPoint, $storage) {
+			/** @var \OCP\Files\Storage $storage */
 			if (!$storage->instanceOfStorage('\OC\Files\Storage\Shared') && !$storage->isLocal()) {
 				return new \OC\Files\Storage\Wrapper\Availability(['storage' => $storage]);
 			}
@@ -294,12 +295,15 @@ public static function isDefaultExpireDateEnforced() {
 	 * @return int Quota bytes
 	 */
 	public static function getUserQuota($user) {
-		$userQuota = \OC::$server->getUserManager()->get($user)->getQuota();
+		$user = \OC::$server->getUserManager()->get($user);
+		if (is_null($user)) {
+			return \OCP\Files\FileInfo::SPACE_UNLIMITED;
+		}
+		$userQuota = $user->getQuota();
 		if($userQuota === 'none') {
 			return \OCP\Files\FileInfo::SPACE_UNLIMITED;
-		}else{
-			return OC_Helper::computerFileSize($userQuota);
 		}
+		return OC_Helper::computerFileSize($userQuota);
 	}
 
 	/**