fix: checkbox now allows shift-click and multi-select

Signed-off-by: Eduardo Morales <emoral435@gmail.com>
nextcloud · Feb 13, 2024 · 3022b23 · 3022b23
1 parent 2c6d11d
commit 3022b23
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/apps/files/js/filelist.js b/apps/files/js/filelist.js
@@ -396,7 +396,7 @@
 				self.do_delete(filename, directory);
 			});
 
-			this.$fileList.on('change', 'td.selection>.selectCheckBox', _.bind(this._onClickFileCheckbox, this));
+			this.$fileList.on('click', 'td.selection', _.bind(this._onClickFileCheckbox, this));
 			this.$fileList.on('mouseover', 'td.selection', _.bind(this._onMouseOverCheckbox, this));
 			this.$el.on('show', _.bind(this._onShow, this));
 			this.$el.on('urlChanged', _.bind(this._onUrlChanged, this));
@@ -944,8 +944,10 @@
 		 * Event handler for when clicking on a file's checkbox
 		 */
 		_onClickFileCheckbox: function(e) {
+			// to prevent double click, prevent default
+			e.preventDefault()
 			var $tr = $(e.target).closest('tr');
-			if(this._getCurrentSelectionMode() === 'range') {
+			if(this._allowSelection && e.shiftKey) {
 				this._selectRange($tr);
 			} else {
 				this._selectSingle($tr);