Skip to content

Commit

Permalink
Remove layout glitches
Browse files Browse the repository at this point in the history
- Make border only 1px
- Revert change to border color of search box
- Add invisible (transparent) 1px border to links in the not-focused state. So the link has the same size in the focused and not-focused state.
  • Loading branch information
LiamHD committed Nov 16, 2016
1 parent 9c02917 commit 6663dc4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion core/css/inputs.css
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ input[type="button"]:focus,
#quota:focus,
.pager li a:focus {
color: #333;
border: 2px solid #0082c9;
border: 1px solid #0082c9;
}

input[type="checkbox"].checkbox {
Expand Down
8 changes: 4 additions & 4 deletions core/css/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
This file is licensed under the Affero General Public License version 3 or later.
See the COPYING-README file. */

html, body, div, span, object, iframe, h1, h2, h3, h4, h5, h6, p, blockquote, pre, a, abbr, acronym, address, code, del, dfn, em, img, q, dl, dt, dd, ol, ul, li, fieldset, form, label, legend, table, caption, tbody, tfoot, thead, tr, th, td, article, aside, dialog, figure, footer, header, hgroup, nav, section { margin:0; padding:0; border:0; outline: 0; font-weight:inherit; font-size:100%; font-family:inherit; vertical-align:baseline; cursor:default; }
a:focus { color: #333; border: 2px solid #0082c9;}
html, body, div, span, object, iframe, h1, h2, h3, h4, h5, h6, p, blockquote, pre, a, abbr, acronym, address, code, del, dfn, em, img, q, dl, dt, dd, ol, ul, li, fieldset, form, label, legend, table, caption, tbody, tfoot, thead, tr, th, td, article, aside, dialog, figure, footer, header, hgroup, nav, section { margin:0; padding:0; border:0; outline:0; font-weight:inherit; font-size:100%; font-family:inherit; vertical-align:baseline; cursor:default; }
a:focus { color: #333; border: 1px solid #0082c9;}
html, body { height:100%; }
article, aside, dialog, figure, footer, header, hgroup, nav, section { display:block; }
body { line-height:1.5; }
table { border-collapse:separate; border-spacing:0; white-space:nowrap; }
caption, th, td { text-align:left; font-weight:normal; }
table, td, th { vertical-align:middle; }
a { border:0; color:#000; text-decoration:none;}
a { border:1px; border-color: transparent; border-style: solid; color:#000; text-decoration:none;}

This comment has been minimized.

Copy link
@jancborchardt

jancborchardt Nov 16, 2016

Member

Um, messing with the reset here and adding 1px of border will most likely screw up the layout. ;)

This comment has been minimized.

Copy link
@LiamHD

LiamHD Nov 16, 2016

Author

Can you show me where this screws up the layout? It looked good on my side. I tested several screens.

a, a *, input, input *, select, .button span, label { cursor:pointer; }
ul { list-style:none; }

Expand Down Expand Up @@ -129,7 +129,7 @@ body {
max-width: 50%;
cursor: text;
background-color: #0082c9;
border: 1px solid #0082c9;
border: 1px solid rgba(255, 255, 255, .5);
}

/* CONTENT ------------------------------------------------------------------ */
Expand Down

0 comments on commit 6663dc4

Please sign in to comment.