Skip to content

Commit

Permalink
fix(oc-dialog): Get rid of the overlay
Browse files Browse the repository at this point in the history
- Icrement Z-index of oc-dialog-dim
- Increment z-index of oc-dialog- Insert oc-dialog-dim before oc-dialog

Co-authored-by: Co-author RayanBekri <rmt.bekri@gmail.com>"
Signed-off-by: JEEEEEEEEEEEEEEEEEEEEEED <118366366+jadjoud@users.noreply.github.com>
  • Loading branch information
jadjoud authored and susnux committed Apr 8, 2024
1 parent ff2100a commit 8e136c3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions core/src/jquery/css/jquery.ocdialog.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
border-radius: var(--border-radius-large);
box-shadow: 0 0 30px var(--color-box-shadow);
padding: 24px;
z-index: 10000;
z-index: 100001;
font-size: 100%;
box-sizing: border-box;
min-width: 200px;
Expand Down Expand Up @@ -69,7 +69,7 @@
.oc-dialog-dim {
background-color: #000;
opacity: .2;
z-index: 9999;
z-index: 100001;
position: fixed;
top: 0;
left: 0;
Expand Down
2 changes: 1 addition & 1 deletion core/src/jquery/ocdialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ $.widget('oc.ocdialog', {
}
this.overlay = $('<div>')
.addClass('oc-dialog-dim')
.appendTo(contentDiv)
.insertBefore(this.$dialog)
this.overlay.on('click keydown keyup', function(event) {
if (event.target !== self.$dialog.get(0) && self.$dialog.find($(event.target)).length === 0) {
event.preventDefault()
Expand Down

0 comments on commit 8e136c3

Please sign in to comment.