Fix #1782

Fix checkbox left margin glitch Fix tests fix unit tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>
nextcloud · Nov 2, 2016 · bc5268b · bc5268b
1 parent ffebc05
commit bc5268b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/apps/theming/lib/Controller/ThemingController.php b/apps/theming/lib/Controller/ThemingController.php
@@ -319,7 +319,7 @@ public function getStylesheet() {
 			$responseCss .= sprintf('input[type="checkbox"].checkbox:checked:enabled:not(.checkbox--white) + label:before {' .
 				'background-image:url(\'%s/core/img/actions/checkmark-white.svg\');' .
 				'background-color: %s; background-position: center center; background-size:contain;' .
-				'width:12px; height:12px; padding:0; margin:2px 6px 6px 2px; border-radius:1px;' .
+				'width:12px; height:12px; padding:0; margin:2px 6px 6px 9px; border-radius:1px;' .
 				"}\n",
 				\OC::$WEBROOT,
 				$elementColor

diff --git a/apps/theming/tests/Controller/ThemingControllerTest.php b/apps/theming/tests/Controller/ThemingControllerTest.php
@@ -428,7 +428,7 @@ public function testGetStylesheetWithOnlyColor() {
 		$expectedData .= sprintf('input[type="checkbox"].checkbox:checked:enabled:not(.checkbox--white) + label:before {' .
 			'background-image:url(\'%s/core/img/actions/checkmark-white.svg\');' .
 			'background-color: %s; background-position: center center; background-size:contain;' .
-			'width:12px; height:12px; padding:0; margin:2px 6px 6px 2px; border-radius:1px;' .
+			'width:12px; height:12px; padding:0; margin:2px 6px 6px 9px; border-radius:1px;' .
 			"}\n",
 			\OC::$WEBROOT,
 			$color
@@ -517,7 +517,7 @@ public function testGetStylesheetWithOnlyColorInvert() {
 		$expectedData .= sprintf('input[type="checkbox"].checkbox:checked:enabled:not(.checkbox--white) + label:before {' .
 			'background-image:url(\'%s/core/img/actions/checkmark-white.svg\');' .
 			'background-color: #555555; background-position: center center; background-size:contain;' .
-			'width:12px; height:12px; padding:0; margin:2px 6px 6px 2px; border-radius:1px;' .
+			'width:12px; height:12px; padding:0; margin:2px 6px 6px 9px; border-radius:1px;' .
 			"}\n",
 			\OC::$WEBROOT
 		);
@@ -691,7 +691,7 @@ public function testGetStylesheetWithAllCombined() {
 		$expectedData .= sprintf('input[type="checkbox"].checkbox:checked:enabled:not(.checkbox--white) + label:before {' .
 			'background-image:url(\'%s/core/img/actions/checkmark-white.svg\');' .
 			'background-color: %s; background-position: center center; background-size:contain;' .
-			'width:12px; height:12px; padding:0; margin:2px 6px 6px 2px; border-radius:1px;' .
+			'width:12px; height:12px; padding:0; margin:2px 6px 6px 9px; border-radius:1px;' .
 			"}\n",
 			\OC::$WEBROOT,
 			$color
@@ -797,7 +797,7 @@ public function testGetStylesheetWithAllCombinedInverted() {
 		$expectedData .= sprintf('input[type="checkbox"].checkbox:checked:enabled:not(.checkbox--white) + label:before {' .
 			'background-image:url(\'%s/core/img/actions/checkmark-white.svg\');' .
 			'background-color: #555555; background-position: center center; background-size:contain;' .
-			'width:12px; height:12px; padding:0; margin:2px 6px 6px 2px; border-radius:1px;' .
+			'width:12px; height:12px; padding:0; margin:2px 6px 6px 9px; border-radius:1px;' .
 			"}\n",
 			\OC::$WEBROOT
 		);