Skip to content

Commit

Permalink
Makes untrusted domain error a warning.
Browse files Browse the repository at this point in the history
It sends a 400 to the client, so I could even argue that it should be an error.

But currently as an admin, I'm quiet surprised that I get a 400 in the UI, and nothing in the log with the default level.

I saw this commit that explains the reason why info. But I disagree.

Feel free to close the PR if you don't agree with it.

Signed-off-by: Pierre Ozoux <pierre@ozoux.net>
  • Loading branch information
pierreozoux committed Jan 25, 2022
1 parent 562c573 commit e6d9ef2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/base.php
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,7 @@ public static function init() {
if (!$isScssRequest) {
http_response_code(400);

\OC::$server->getLogger()->info(
\OC::$server->getLogger()->warning(
'Trusted domain error. "{remoteAddress}" tried to access using "{host}" as host.',
[
'app' => 'core',
Expand Down

0 comments on commit e6d9ef2

Please sign in to comment.