do onetime user setup before getting any mount from providers

this fixes a race condition where wrappers weren't properly applied if when a mount provider creates the storage instance one mountpoint creation instead of lazily

Signed-off-by: Robin Appelman <robin@icewind.nl>

lib/private/Files/SetupManager.php

@@ -232,11 +232,13 @@ public function setupForUser(IUser $user): void {
 	 * part of the user setup that is run only once per user
 	 */
 	private function oneTimeUserSetup(IUser $user) {
-		if (in_array($user->getUID(), $this->setupUsers, true)) {
+		if ($this->isSetupStarted($user)) {
 			return;
 		}
 		$this->setupUsers[] = $user->getUID();
 
+		$this->setupRoot();
+
 		$this->setupBuiltinWrappers();
 
 		$prevLogging = Filesystem::logWarningWhenAddingStorageWrapper(false);
@@ -306,11 +308,7 @@ private function afterUserFullySetup(IUser $user, array $previouslySetupProvider
 	 * @throws \OC\ServerNotAvailableException
 	 */
 	private function setupForUserWith(IUser $user, callable $mountCallback): void {
-		$this->setupRoot();
-
-		if (!$this->isSetupStarted($user)) {
-			$this->oneTimeUserSetup($user);
-		}
+		$this->oneTimeUserSetup($user);
 
 		$this->eventLogger->start('setup_fs', 'Setup filesystem');
 
@@ -409,9 +407,7 @@ public function setupForPath(string $path, bool $includeChildren = false): void
 			return;
 		}
 
-		if (!$this->isSetupStarted($user)) {
-			$this->oneTimeUserSetup($user);
-		}
+		$this->oneTimeUserSetup($user);
 
 		$mounts = [];
 		if (!in_array($cachedMount->getMountProvider(), $setupProviders)) {
@@ -488,6 +484,8 @@ public function setupForProvider(string $path, array $providers): void {
 			return;
 		}
 
+		$this->oneTimeUserSetup($user);
+
 		// home providers are always used
 		$providers = array_filter($providers, function (string $provider) {
 			return !is_subclass_of($provider, IHomeMountProvider::class);