Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined download button not working in public share 14.0.0 Beta 2 #10536

Closed
s644 opened this issue Aug 4, 2018 · 4 comments
Closed

Combined download button not working in public share 14.0.0 Beta 2 #10536

s644 opened this issue Aug 4, 2018 · 4 comments
Labels
Milestone

Comments

@s644
Copy link

s644 commented Aug 4, 2018

Steps to reproduce

  1. Create public share link with at least 2 files
  2. open public link
  3. tick single file and hit Actions/Download Button for combined download

Expected behaviour

.zip file should be served

Actual behaviour

page reloads

Server configuration

Operating system:
OMV 4

Web server:
nginx
Database:
mysql
PHP version:
php7
Nextcloud version: (see Nextcloud admin page)
14.0.0 Beta 2 (also with Beta 1)
Updated from an older Nextcloud/ownCloud or fresh install:
Updated from 13
Where did you install Nextcloud from:
Internal Updater

Browser log

Browser log
js failure:

TypeError: self.fileMultiSelectMenu is null

in file   /apps/files/js/filelist.js:350:5

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #4901 (Updater won't work in 12.0 beta 2), #6159 (12.0.2 After upgrade files missing and button "upgrade" doesn't work), #9434 (Public Sharing), #10495 (14 Beta 2), and #920 (Wrong Text on Download Button at Public Shares).

@MartB
Copy link
Member

MartB commented Aug 4, 2018

Was broken by 45db89f

Edit (hit submit too early ...)
The block inside the if is not getting called because options.multiSelectMenu is not set.
45db89f#diff-dafefd9519924bec4efa9f5af4af8e68R296 thus resulting in "is undefined ..." and reloading the page.

If you force that check to true it still wont work because the required javascript is not included by default, if you manually include it the menu that is shown is broken. (Because it never has any actions set)

The real culprit is that the original author never tested his implementation for file shares.

The following initialization logic fixes the behaviour for the normal files app:
45db89f#diff-9ca226525aa6188a8eca690db89badee

Edit:
I will fix it and submit a pr later today.

MartB added a commit to MartB/server that referenced this issue Aug 4, 2018
Signed-off-by: MartB <mart.b@outlook.de>
MartB added a commit to MartB/server that referenced this issue Aug 4, 2018
Signed-off-by: Martin Böh (MartB) <mart.b@outlook.de>
@stratege1401
Copy link

your missing the 14-feedback-beta ...

@rullzer rullzer added this to the Nextcloud 14 milestone Aug 6, 2018
MartB added a commit to MartB/server that referenced this issue Aug 6, 2018
Signed-off-by: Martin Böh (MartB) <mart.b@outlook.de>
@rullzer rullzer mentioned this issue Aug 6, 2018
58 tasks
rullzer added a commit that referenced this issue Aug 9, 2018
Fix multiSelectMenu for public shares #10536
weeman1337 pushed a commit that referenced this issue Aug 9, 2018
Signed-off-by: Martin Böh (MartB) <mart.b@outlook.de>
@rullzer
Copy link
Member

rullzer commented Aug 10, 2018

Fixed with #10537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants