Basic auth requests always set up the filesystem

[nickvergessen]

ToDo

• remove support for old chunking v1 in Desktop

If a request is authenticated and does not use cookies, it will always set up the filesystem.
The reason is the post-login gc we do:

server/lib/base.php

Lines 815 to 831 in e6d9ef2

	try {
	$cache = new \OC\Cache\File();
	$cache->gc();
	} catch (\OC\ServerNotAvailableException $e) {
	// not a GC exception, pass it on
	throw $e;
	} catch (\OC\ForbiddenException $e) {
	// filesystem blocked for this request, ignore
	} catch (\Exception $e) {
	// a GC exception should not prevent users from using OC,
	// so log the exception
	\OC::$server->getLogger()->logException($e, [
	'message' => 'Exception when running cache gc.',
	'level' => ILogger::WARN,
	'app' => 'core',
	]);
	}

I think it is time to move that to a proper cron job instead. It would potentially clean up chunked upload attempts but there is no need to do this with every successful login?!

[PVince81]

I think chunked upload cleanup already has a cron job: #30772

[juliushaertl]

This seems to only cleanup parts from the very old chunking https://github.com/owncloud/core/wiki/spec%3A-big-file-chunking, mabye something we can get rid of then.

@tobiasKaminsky can maybe check if that is still used in any way in the clients as I found at least a code occurence for desktop: https://github.com/nextcloud/desktop/blob/4135b757b9599f95376a416761ad5cf3116411a9/src/libsync/propagateuploadv1.cpp#L115 but I'd think everything is using the new chunked upload anyways

[juliushaertl]

Other than that there seems to be no usage of the \OC\Cache\File class which contains the garbage collection

[tobiasKaminsky]

Discussed with @mgallien we will remove support with 3.7 and announce this in release notes.
As we have our chunked uploading mechanism this is is a decent replacement.

[juliushaertl]

Is this being used as a fallback only? Would it be a problem for older clients of we drop the support in server e.g. for 26?

[mgallien]

Is this being used as a fallback only? Would it be a problem for older clients of we drop the support in server e.g. for 26?

the new chunking algorithm has been released with 2.3.0 desktop client release from Mar 3, 2017
I think it is safe to assume clients have upgraded or we can ask them to upgrade

I mean that it should be safe to remove this deprecated code in the 26 server release

[tobiasKaminsky]

@mgallien once you have removed it in Desktop, please link it here, so that we have this for reference :)

[nickvergessen]

We can bump

server/apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php

Line 67 in f7be761

$minimumSupportedDesktopVersion = $this->config->getSystemValue('minimum.supported.desktop.version', '2.0.0');

to be sure

[mgallien]

We can bump

server/apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php

Line 67 in f7be761

$minimumSupportedDesktopVersion = $this->config->getSystemValue('minimum.supported.desktop.version', '2.0.0');

to be sure

see #35425
I did it directly

[juliushaertl]

Another usage is any class that injects ICache:

server/lib/private/Server.php

Lines 706 to 710 in 7c4ceb4

	$this->registerService(ICache::class, function ($c) {
	return new Cache\File();
	});
	/** @deprecated 19.0.0 */
	$this->registerDeprecatedAlias('UserCache', ICache::class);

Might be harder to find all cases, but maybe we can actually switch this to a ArrayCache or local memory cache instance instead.

[juliushaertl]

Reopening since #36589 was reverted for now

[juliushaertl]

#36787 has details about the issues that were caused