Public page styles are broken on

[eppfel]

I could reproduce @ChristophWurst find:

I looked into it and it seems there all stylesheets with the route /css/core/ are missing (e.g styles.css) .

There is definitely something wrong with the routing/embedding...

@skjnldsv @MorrisJobke

[skjnldsv]

This is strange, because I was testing stuff yesterday for #3187 and everything was working fine!
#3187 (comment)

[skjnldsv]

This comes from bde1150
I will take a look asap!

[eppfel]

Just reassured. I am on master, Chrome 55∞ macOS 10.11.6.

It could have to do with the prettyURLs, but very likely with URLGenerator... Did not see your new comment

[skjnldsv]

No, this is a easy one:
https://github.com/nextcloud/server/blob/master/lib/private/TemplateLayout.php#L167

// Do not initialise scss appdata until we have a fully installed instance
// Do not load scss for update, errors, installation or login page
if(\OC::$server->getSystemConfig()->getValue('installed', false)
    && !\OCP\Util::needUpgrade()
    && \OC_User::isLoggedIn()) {
	$cssFiles = self::findStylesheetFiles(\OC_Util::$styles);
} else {
	$cssFiles = self::findStylesheetFiles(\OC_Util::$styles, false);
}

I didn't realised that public pages don't have a logged-in user!

[MorrisJobke]

\OC_User::isLoggedIn()

The problem seems to be here: why do you disable the SCSS for non-logged in users? The login page should also be done within SCSS.

[MorrisJobke]

Is there a way to move CSS and SCSS into different namespaces? So that we know if it is CSS or SCSS - relying on some magic under the hood is always confusing and causes weird bugs as above.

[MorrisJobke]

Fix is in #3223

[ChristophWurst]

Reopening because the bug is still not fixed for 2FA pages:

[MorrisJobke]

Separate issue -> moved to a new issue.