[Bug]: $time must not be accessed before initialization #35543
Comments
pgaufillet
added
0. Needs triage
|
cc @come-nc |
|
I can confirm this bug. |
|
I can confirm this bug. |
|
Can confirm this bug. |
|
Same here @ |
|
same here... |
|
Same on docker |
|
This looks like a subclass of TimedJob that bypasses the constructor. So far I only found this with the TimedJob from OC, but your trace shows it comes from the TimedJob of OCP. Could one of you give the result of "occ background-job:list --limit=100" ? |
|
result of "occ background-job:list --limit=100" |
|
Thank you. |
|
And it is my fault 😭 nextcloud/files_antivirus@ba33506 |
|
I have the files_antivirus application enabled. |
|
Can someone confirm that this fixes the problem: https://patch-diff.githubusercontent.com/raw/nextcloud/files_antivirus/pull/254.diff ? |
|
Patch applied. Next invocation of the faulty piece of code scheduled at 14:00. Is there a mean to force the execution? |
|
Patch applied |
|
Thanks for the patch. I've applied it as well and next run will be 15:11 |
|
No more error in the journal. Thanks 👍 |
|
Also from my side, the problem seems to be fixed. |
|
Thank you @come-nc for the quick fix and release of files_antivirus 4.0.1 😊 |
|
Great, thanks that someone fixed the bug.But I am not a computer specialist, so I don't know how to apply or to type in the code given in the patch link. Can someone explain? Thanks a lot. |
|
@rkrenzin I'm pretty sure the commit has been pushed out. You can just update your Antivirus for Files app through the Nextcloud browser interface like you normally do for any other update. |
No need, should be included in the 4.0.1 release (which isn't on github's release page but it is via Nextcloud apps management). Otherwise (for the sake of learning), https://patch-diff.githubusercontent.com/raw/nextcloud/files_antivirus/pull/254.diff (the patch supplied on December 5 by come-nc) shows the differences between the old Since that path is relative to the application's path, the full path to that file would be As for how diff works: https://en.wikipedia.org/wiki/Diff |
|
@Steve8291 Many thanks for the quick replay. I've just updated antivirus and will see if the error message will not appear again. @Kwarde666 I appreciate your additional explanations. Many thanks. Learning is always good :-) |
|
@Kwarde666 Is all the code just one command to be copied in the command line of the terminal window? |
|
@rkrenzin No. |
|
hello! 2024-02-23T02:20:01.418631023Z Error: Typed property OCP\BackgroundJob\Job::$time must not be accessed before initialization in /var/www/html/lib/public/BackgroundJob/TimedJob.php:101 result of “occ background-job:list --limit=100” : |
See eldertek/duplicatefinder#57 |
Thanks a lot! |
|
For consideration - perhaps error handling for BackgroundJob could be improve to point out in a more obvious way which job is causing issues. (without the need to use the occ command). |
|
same error for me -- nextcloud 28.0.4 do not know hopw to apply the patch provided by @come-nc (#35543 (comment)) Thanks a lot for your help |
|
@vgrosdoy |
|
@vgrosdoy No patching is needed this patch was released already. |
|
it seems the issue was due to DuplicateFinder addons |
Bug description
Since the upgrade to NC 25, the following error pops up during the execution of cron jobs only at 02:00 and 14:00:
Steps to reproduce
Expected behavior
No error ;-)
Installation method
Community Web installer on a VPS or web space
Operating system
Debian/Ubuntu
PHP engine version
PHP 7.4
Web server
Apache (supported)
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
Updated to a major version (ex. 22.2.3 to 23.0.1)
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
Configuration report
php occ config:list system { "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "***REMOVED SENSITIVE VALUE***", "***REMOVED SENSITIVE VALUE***" ], "check_for_working_wellknown_setup": false, "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "25.0.1.1", "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "default_language": "fr", "default_locale": "fr_FR", "installed": true, "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_sendmailmode": "smtp", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "25", "maintenance": false, "overwritehost": "***REMOVED SENSITIVE VALUE***", "overwriteprotocol": "https", "overwritewebroot": "***REMOVED SENSITIVE VALUE***", "overwritecondaddr": "***REMOVED SENSITIVE VALUE***", "theme": "", "trusted_proxies": "***REMOVED SENSITIVE VALUE***", "loglevel": 2, "memcache.local": "\\OC\\Memcache\\APCu", "updater.release.channel": "stable", "mysql.utf8mb4": true, "default_phone_region": "FR", "trashbin_retention_obligation": "60,60" } }List of activated Apps
Nextcloud Signing status
Nextcloud Logs
{"reqId":"SztDoEXmh8SzATpc1HMk","level":3,"time":"2022-12-01T13:00:03+00:00","remoteAddr":"","user":"--","app":"cron","method":"","url":"/nextcloud/cron.php","message":"Typed property OCP\\BackgroundJob\\Job::$time must not be accessed before initialization","userAgent":"--","version":"25.0.1.1","exception":{"Exception":"Error","Message":"Typed property OCP\\BackgroundJob\\Job::$time must not be accessed before initialization","Code":0,"Trace":[{"file":"/var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php","line":93,"function":"start","class":"OCP\\BackgroundJob\\TimedJob","type":"->"},{"file":"/var/www/nextcloud/cron.php","line":152,"function":"execute","class":"OCP\\BackgroundJob\\TimedJob","type":"->"}],"File":"/var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php","Line":102,"CustomMessage":"--"}}Additional info
No response
The text was updated successfully, but these errors were encountered: