Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use primary colour for luminance calculations if background is disabled #35664

Closed
skjnldsv opened this issue Dec 8, 2022 · 1 comment · Fixed by #35666
Closed

Use primary colour for luminance calculations if background is disabled #35664

skjnldsv opened this issue Dec 8, 2022 · 1 comment · Fixed by #35666
Assignees
Labels
Milestone

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Dec 8, 2022

Well, how can we know if the background you selected has a bright top header? We're gonna improve for 26, but until then, it's not a bug, just not implemented.

@skjnldsv At least you could know if one has selected like #ffffff in the color picker. Not talking about background image. In fact any picked color tending towards white makes the GUI unusable right now. Call it a bug or broken by design. It is an issue. As long as you cannot set it dynamically, a small toggle switch (switch between light and dark header icons) could also do the trick. Quick and easy.

Originally posted by @HannesJo0139 in #34965 (comment)

@skjnldsv skjnldsv self-assigned this Dec 8, 2022
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of feature: theming bug labels Dec 8, 2022
@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Dec 8, 2022
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of 25-feedback 26-feedback labels Dec 8, 2022
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 8, 2022

26 fix in #35666
Will have to adjust for 25 as lots have improved for 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants