Invert header if primary is bright and background disabled #35666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
PVince81 and
szaimen
and removed request for
a team
skjnldsv
force-pushed
the
fix/header-bright-no-bg
branch
2 times, most recently
from
c8031d3
to
4368706
Compare
skjnldsv
commented
Dec 8, 2022
| @@ -95,8 +95,10 @@ protected function generateGlobalBackgroundVariables(): array { | |||
| // If primary as background has been request or if we have a custom primary colour | |||
| // let's not define the background image | |||
| if ($backgroundDeleted) { | |||
| $variables['--color-background-plain'] = $this->themingDefaults->getColorPrimary(); | |||
| $variables['--color-background-plain'] = $this->defaultPrimaryColor; | |||
There was a problem hiding this comment.
This change is intentional.
We're in the admin section, we should use defaultPrimaryColor instead of primaryColor
If logged in, this var will be overruled below in the user section
There was a problem hiding this comment.
Could you explain their differences ?
There was a problem hiding this comment.
defaultPrimaryColor = admin defined, instance-wide
primaryColor = user, active for current session
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
artonge
requested changes
Dec 8, 2022
skjnldsv
force-pushed
the
fix/header-bright-no-bg
branch
from
6e2ee9a
to
0cf7609
Compare
artonge
approved these changes
Dec 8, 2022
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/header-bright-no-bg
branch
from
0cf7609
to
1acd42e
Compare
skjnldsv
added
4. to release
Pytal
approved these changes
Dec 8, 2022
|
Failure unrelated |
4 tasks
skjnldsv
commented
Jul 6, 2023
| @@ -132,14 +132,57 @@ describe('Remove the default background and restore it', function() { | |||
| }) | |||
| }) | |||
|
|
|||
| describe.only('Remove the default background with a bright color', function() { | |||
There was a problem hiding this comment.
Suggested change
| describe.only('Remove the default background with a bright color', function() { | |
| describe('Remove the default background with a bright color', function() { |
🙄
There was a problem hiding this comment.
I'll take the walk of shame 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #35664