[BITV]: Sharing tab: There is no indicator that "advanced settings" are open

[JuliaKirschenheuter]

There is no indicator that "advanced settings" are open which have to be a case. I would prefer a toggle button instead.

@nimishavijay @marcoambrosini could we replace a button with a toggle one?

The description and toggle state have to be visible for screen readers too.

[nimishavijay]

We could change the icon on the right to the expand-more icon when it is closed and the expand-less icon when it is open, would that be enough? :)

[marcoambrosini]

@nimishavijay shouldn't that icon be on the left btw?

[JuliaKirschenheuter]

Thank you!
I would like to know why a toggle button is wrong on that place? An icon won't solve all a11y issues. Semantically it is a toggle button. @nimishavijay please help. Thank you!

[susnux]

I would say the triangle icon needs to point down if open and right if closed. Also I would make the button full width to look like a heading and group the controlled section, like using background?

Something like this?

[marcoambrosini]

@JuliaKirschenheuter could you link some documentation about why this should be a toggle? If this is the case, we'd have to change the pattern in many places in Nextcloud.
As far as UX goes, toggles don't seem to be recommended for progressively disclose content https://www.nngroup.com/articles/toggle-switch-guidelines/

The pattern we're using is an accordion, so a button with aria-expanded="true | false" would suffice as a header. There's no need of any other visual indicators.

[susnux]

so a button with aria-expanded="true | false" would suffice as a header.

And the aria-controlled region tag.

[JuliaKirschenheuter]

could you link some documentation about why this should be a toggle?

I thought that would be better on this place. But you are right, lets move with accordion 👍