Adapt "advanced settings" button for accordion button #41473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaKirschenheuter
requested review from
ShGKme,
susnux,
marcoambrosini,
szaimen and
Pytal
Pytal
approved these changes
Nov 14, 2023
JuliaKirschenheuter
force-pushed
the
fix/41306-Sharing_tab_There_is_no_indicator_that_advanced_settings_are_open
branch
from
b010fe3
to
1f3a7ec
Compare
ShGKme
approved these changes
Nov 14, 2023
susnux
approved these changes
Nov 14, 2023
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
susnux
force-pushed
the
fix/41306-Sharing_tab_There_is_no_indicator_that_advanced_settings_are_open
branch
from
1f3a7ec
to
7c987f0
Compare
marcoambrosini
approved these changes
Nov 15, 2023
|
cypress unrelated |
susnux
deleted the
fix/41306-Sharing_tab_There_is_no_indicator_that_advanced_settings_are_open
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relied on https://www.w3.org/WAI/ARIA/apg/patterns/accordion/ and https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/
Before
After
Checklist