-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ποΈ "Personal files" view #42919
Comments
Updated title and description a bit, so it's clear it should be "Personal files" instead of "My". Otherwise good to go, and let's go with an entry then as it's easier to understand than a setting. |
Also cc @tobiasKaminsky on this regarding adding this to mobile apps. |
So it would be list of root with
clicking on any of those folders would then show entire content of this folder, or also only limited to above criteria? (would be harder to do) |
@tobiasKaminsky, @sorbaugh edited the first post and lost Jan's description, I added it back :) |
Thanks for the correction and update of the description in the issue @skjnldsv That now matches also my understanding of how it is supposed to work / the filter to be done π |
I would say yes |
Let me re-ask this again :-) |
@tobiasKaminsky Just based off of the description, I assuming that it is limited to the above criteria. In specific,
So, if my understanding is correct, this would mean that we would have to filter even Files/Nodes within each folder to see if it is shared, etc |
@tobiasKaminsky @emoral435 according to the comment at https://github.com/nextcloud-gmbh/customer-feature-requests/issues/404#issuecomment-1556626596, the root level is the mainly important one. So since it is likely a lot more work to filter it out at every step, it would make more sense to just start with that? @AndyScherzinger |
Fine by me π Only thing that is not covered then given the referenced comment @jancborchardt https://github.com/nextcloud-gmbh/customer-feature-requests/issues/404#issuecomment-1556626596 is
and maybe
Simply because I am not sure if this is easily detectable and if the file ownership is actually with the user and not the sharing party. @sorbaugh can you check this with the team. |
As I understand this, it means
--> then it would also fit in my "assumption" to have this filter only on top level
Same here. This is shown in root view, and content is also shown, as in subfolder those filter does not apply |
@jancborchardt do we wanna have another icon? |
Just to get a final confirmation from @AndyScherzinger and @jancborchardt , the filter should only apply to the root folder within the personal files view, correct? I agree with Tobias' assumption |
As far as I read it, yes ππ |
Adding some details here that might get lost due to the discussion taking place in the PR. There is a breadcrumb optimization that was added to the Personal Files View that needs to be applied to all other Files Views as well for consistency. Will create a separate issue so we can get this issue merged and closed while still tracking the Breadcrumb optimization. See: #43211 (comment) |
@emoral435 thanks for the work here ! this one has been expected for a long time and will make happy a lot of people :) |
Context
With heavy use of Group Folders, the
All Files
menu view is confusing for the user who gets his/her personal files mixing with organization files. Currently there is no option on top level to have filtered view only showing a user their own files.Describe the solution you'd like
Add an entry
Personal files
to the left menu, directly belowAll files
, showing:The text was updated successfully, but these errors were encountered: