Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: personal file view #43211

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Conversation

emoral435
Copy link
Contributor

@emoral435 emoral435 commented Jan 30, 2024

Issue Summary

Resolves #42919

OVERVIEW / FRONTEND LOOK

Quick GIF View

firefox_UlvxgyFkts

File sharing comparison

🏚️ Admin View 🏡 Janes View
admin all files jane all files
image image
admin personal files (root) jane personal files (root
image firefox_KumFQsCbr2

Clarifications

  • User clicks on "Personal Files" from the Sidebar, and using folder API's, filters group-folders, shared folders/files that do not belong to the User
  • When a folder is shared to another person, any file or folder that person makes belongs to whoever the 'root' folder belongs too

Implementation

  • Added new view to the files view that filters each file/folder that the user uploaded / created / owns
  • Each view from there filters out each sub-file that they did not upload / create / own, but only is really important at the root level

TODO

  • Add tests to personal views

Checklist

@emoral435

This comment was marked as resolved.

@emoral435 emoral435 self-assigned this Jan 30, 2024
@emoral435 emoral435 added this to the Nextcloud 29 milestone Jan 30, 2024
@emoral435 emoral435 force-pushed the feature/person-files-view/42919/base-draft branch 6 times, most recently from a994ff3 to 866e810 Compare February 2, 2024 18:17
@emoral435 emoral435 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 2, 2024
@emoral435 emoral435 marked this pull request as ready for review February 2, 2024 18:21
@emoral435
Copy link
Contributor Author

TLDR for the reviewers:

  • Need a review from the design team to know I can go forward with making tests for the view 👍
  • Checkup with @tobiasKaminsky to see if our assumptions are similar so that the mobile and web team can be on the same page
  • My fellow frontend reviewers to absolutely cook this PR for any flawed logic 🙏🙈

If anything needs clarification, just let me know!

@nimishavijay

This comment was marked as resolved.

jancborchardt

This comment was marked as resolved.

@emoral435

This comment was marked as resolved.

@emoral435
Copy link
Contributor Author

emoral435 commented Feb 6, 2024

firefox_QiHyTJ2z9W

@nimishavijay This is how the implementation looks! IMO, I think that having this now makes this view look a bit different from the rest - I think that having the rest of the views have something similar where we append the view name at the end of the file name would now make this much cleaner, no? This is certainly possible as well.

EDIT: also talked with @skjnldsv and we agreed that the breadcrumbs, in our personal opinion, should have this change applied to each view :) it would easy to implement as well!

EDIT2: cc @nimishavijay , forgot to cc again last week after guided PR with frontenders😅

@emoral435 emoral435 force-pushed the feature/person-files-view/42919/base-draft branch from b304924 to d156fa6 Compare February 12, 2024 14:24
@emoral435
Copy link
Contributor Author

emoral435 commented Feb 13, 2024

UPDATE: We need to get this issue merged in ASAP for the next major release, so for now, the design aspect with the breadcrumbs can be left for another PR! Will adjust this accordingly, leaving the other PR that may be used for later!

@emoral435 emoral435 force-pushed the feature/person-files-view/42919/base-draft branch from d156fa6 to 22d41d3 Compare February 13, 2024 19:06
@emoral435 emoral435 force-pushed the feature/person-files-view/42919/base-draft branch from 22d41d3 to 7e220cc Compare February 14, 2024 14:50
@emoral435 emoral435 dismissed jancborchardt’s stale review February 14, 2024 14:53

got approval on talk from design team that everything is good now :)

@emoral435 emoral435 changed the title feature: personal views feature: personal file view Feb 14, 2024
@emoral435 emoral435 force-pushed the feature/person-files-view/42919/base-draft branch 2 times, most recently from 6863069 to 8226e26 Compare February 14, 2024 15:32
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One lint issue, otherwise LGTM

@emoral435 emoral435 force-pushed the feature/person-files-view/42919/base-draft branch from 8226e26 to 8e681fd Compare February 14, 2024 17:50
@emoral435
Copy link
Contributor Author

Enabling auto-merge to hopefully get the feature out by Thursday night 👍

@emoral435 emoral435 force-pushed the feature/person-files-view/42919/base-draft branch from 8e681fd to 3c9e1fc Compare February 15, 2024 02:33
@skjnldsv
Copy link
Member

Why is psalm suddenly failing 🤦

emoral435 and others added 7 commits February 15, 2024 09:03
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the feature/person-files-view/42919/base-draft branch from 915ecf5 to 0fa226e Compare February 15, 2024 08:03
@skjnldsv skjnldsv merged commit 4bc1701 into master Feb 15, 2024
92 of 96 checks passed
@skjnldsv skjnldsv deleted the feature/person-files-view/42919/base-draft branch February 15, 2024 08:35
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🗃️ "Personal files" view
6 participants