-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log-in page fonts/logo design #4585
Comments
Huh, could this be related to the SCSS switch @skjnldsv? Do you have any theming active @MariusBluem, or can you pinpoint a commit where this started to happen? |
The font stuff since quite a while ... did not report it, because I thought you all know 😜 No theming active 🤔 |
Never expect this ;) Especially if there’s no existing issue. Are you familiar with git bisect? Or do you want to learn it? ;) Finding out which commit caused it would be a great help, as I’m a bit busy today :\ |
@jancborchardt this is likely because the login page only uses the guests.css and some rules in there are in the wrong order. We tried to get everything in them at was on the page before but it seems something didn't made it. A bisect doesn't help that much. Better look into the "why are rules for font style not applied" instead of looking for the commit(which is 99.9% the scss one and reverting that is out of scope) |
For me this is the case 😕 |
Fix is in #4866 |
Fix is at #4910, please review @juliushaertl @MorrisJobke @MariusBluem :) |
Fix logo being too big on log in page, fix #4585
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
current
master
:latest
stable11
:@jancborchardt @nextcloud/designers
The text was updated successfully, but these errors were encountered: